Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(operator): sanitize app name annotation from uppercase to lowercase #1793

Merged
merged 3 commits into from
Jul 28, 2023

Conversation

RealAnna
Copy link
Contributor

@RealAnna RealAnna commented Jul 27, 2023

fixes #1790

@RealAnna RealAnna requested a review from a team as a code owner July 27, 2023 13:45
@netlify
Copy link

netlify bot commented Jul 27, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit dcde670
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/64c27505381eea000820e7a5
😎 Deploy Preview https://deploy-preview-1793--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@RealAnna RealAnna changed the title Fix/1790/stringlower appname fix(operator): sanitize app name annotation from uppercase to lowercase Jul 27, 2023
@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Merging #1793 (ac5c4d1) into main (a9ac9f6) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1793      +/-   ##
==========================================
- Coverage   63.54%   63.51%   -0.03%     
==========================================
  Files         143      143              
  Lines       10918    10921       +3     
==========================================
- Hits         6938     6937       -1     
- Misses       3719     3722       +3     
- Partials      261      262       +1     
Files Changed Coverage Δ
...rator/webhooks/pod_mutator/pod_mutating_webhook.go 75.34% <100.00%> (+0.20%) ⬆️

... and 1 file with indirect coverage changes

Flag Coverage Δ
certificate-operator 68.55% <ø> (ø)
component-tests 58.13% <ø> (-0.82%) ⬇️
lifecycle-operator 84.91% <100.00%> (+<0.01%) ⬆️
metrics-operator 82.49% <ø> (ø)
scheduler 32.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

thisthat
thisthat previously approved these changes Jul 27, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@RealAnna RealAnna merged commit 0986360 into main Jul 28, 2023
@RealAnna RealAnna deleted the fix/1790/stringlower_appname branch July 28, 2023 06:37
prakrit55 pushed a commit to prakrit55/lifecycle-toolkit that referenced this pull request Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pod pending Deployment failed on 0.8.1
3 participants